From 632579dc2094cc342929261c89e689f0dd358284 Mon Sep 17 00:00:00 2001
From: Bjorn Lu <bjornlu.dev@gmail.com>
Date: Wed, 23 Aug 2023 17:52:53 +0800
Subject: [PATCH] Prevent bundling sharp (#8196)

---
 .changeset/spicy-stingrays-cheer.md           |  5 ++++
 .../core/build/plugins/plugin-internals.ts    | 25 ++++++++++---------
 2 files changed, 18 insertions(+), 12 deletions(-)
 create mode 100644 .changeset/spicy-stingrays-cheer.md

diff --git a/.changeset/spicy-stingrays-cheer.md b/.changeset/spicy-stingrays-cheer.md
new file mode 100644
index 000000000000..19a56cda3d0b
--- /dev/null
+++ b/.changeset/spicy-stingrays-cheer.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Prevent bundling sharp as it errors in runtime
diff --git a/packages/astro/src/core/build/plugins/plugin-internals.ts b/packages/astro/src/core/build/plugins/plugin-internals.ts
index a92b5ac265b7..6bf00f9dc537 100644
--- a/packages/astro/src/core/build/plugins/plugin-internals.ts
+++ b/packages/astro/src/core/build/plugins/plugin-internals.ts
@@ -1,4 +1,4 @@
-import type { UserConfig, Plugin as VitePlugin } from 'vite';
+import type { Plugin as VitePlugin } from 'vite';
 import type { BuildInternals } from '../internal.js';
 import type { AstroBuildPlugin } from '../plugin';
 import { normalizeEntryId } from './plugin-component-entry.js';
@@ -8,19 +8,20 @@ export function vitePluginInternals(input: Set<string>, internals: BuildInternal
 		name: '@astro/plugin-build-internals',
 
 		config(config, options) {
-			const extra: Partial<UserConfig> = {};
-			const noExternal = [],
-				external = [];
 			if (options.command === 'build' && config.build?.ssr) {
-				noExternal.push('astro');
-				external.push('shiki');
+				return {
+					ssr: {
+						// Always bundle Astro runtime when building for SSR
+						noExternal: ['astro'],
+						// Except for these packages as they're not bundle-friendly. Users with strict package installations
+						// need to manually install these themselves if they use the related features.
+						external: [
+							'shiki', // For syntax highlighting
+							'sharp', // For sharp image service
+						],
+					},
+				};
 			}
-
-			extra.ssr = {
-				external,
-				noExternal,
-			};
-			return extra;
 		},
 
 		async generateBundle(_options, bundle) {