Fix Cms/Classes not found when CMS module isn't loaded in config/cms.php #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienAdB
changed the title
AdrienAdB
changed the title
bennothommo
reviewed
Jul 3, 2023
Comment on lines
+111
to
+113
| if (!class_exists(CmsPage::class)) { | ||
| return $result; | ||
| } |
There was a problem hiding this comment.
@AdrienAdB you can probably drop the second class existence checks - if the Theme class is there, it's pretty much a given that the CmsPage class will also be there.
Suggested change
| if (!class_exists(CmsPage::class)) { | |
| return $result; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #43
Cms/Classes not found when CMS module isn't loaded in config/cms.php