Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - crashing studio while trying to open object` #5

Closed
Khalsa-jio opened this issue Apr 20, 2024 · 5 comments · Fixed by #6
Closed

BUG - crashing studio while trying to open object` #5

Khalsa-jio opened this issue Apr 20, 2024 · 5 comments · Fixed by #6
Assignees
Labels
bug Something isn't working

Comments

@Khalsa-jio
Copy link

Hello,

I appreciate your efforts! However, I've encountered a few issues while using this plugin and thought it would be beneficial to bring one to your attention.

Here's how you can reproduce the issue:

Without selecting any type, click on the toggle button. After doing so, I consistently receive an error when attempting to reopen it.Screenshot 2024-04-20 at 5 13 18 PM

@marcusforsberg marcusforsberg self-assigned this Apr 22, 2024
@marcusforsberg marcusforsberg added the bug Something isn't working label Apr 22, 2024
@marcusforsberg marcusforsberg linked a pull request Apr 22, 2024 that will close this issue
@Khalsa-jio
Copy link
Author

@marcusforsberg - Hi mate, I also found currently blank field doesn't show when selecting internal and also seems need to add blank field in LinkValue type...

@marcusforsberg
Copy link
Member

@Khalsa-jio Thanks for the heads-up! The crash and the missing "blank" field were caused by the same issue and the fix was just pushed in v1.1.1. Please give it a go and let me know if it works better for you now.

The blank property is not available in the LinkValue type itself since it's not relevant for all field types; specifically "phone" and "email" links do not have the "blank" option at all. The blank type is available on the InternalLink, ExternalLink and CustomLink types. There are type guards available to check the type of link you're dealing with: isInternalLink, isExternalLink, isEmailLink, isPhoneLink and isCustomLink.

@Khalsa-jio
Copy link
Author

thanks for clearing this out, I will try it and will update you if I find any other issue with it, thanks

@Khalsa-jio
Copy link
Author

Also I was thinking it would be good to add another option for File type link, please let me know if you would like me to do something related to it, thanks

@marcusforsberg
Copy link
Member

No worries! 😊 Feel free to open a new issue explaining your use case and ideas for the File type link and we can take it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants