-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arguments to docs #1565
Comments
First of all, if you check documentation, e. g. the |
I apologise, I'll try to be more civil; I've just been poring over these docs and am a little frustrated to find that an apparently widely used and popular library like this doesn't seem to actually specify how its used in its own docs. It seems this has caused issues in the past: #1427. In fact I was specifically looking for information on whether multiple parameters were supported due to some of the examples. I would love to send a PR to add this information to the documentation, however I do not know what arguments the logger accepts myself, and so I cannot help to add this. |
I've edited the original comment to remove some of my clear frustration. |
Thank you! |
Problem with the examples is they don't show the output: https://github.com/winstonjs/winston/blob/master/examples/custom-pretty-print.js#L17 Like here, how will this be logged? |
I guess the only way to know is to try different combinations in IDE and document that. |
Thanks for the feedback. Variable-arity is challenging to document without being overly verbose – hence why we've gone with examples. An assumption of a user was that they would actually run the examples (i.e. a hands-on approach). Trying to consolidate the most common incantations into |
The documentation, while being very detailed, doesn't seem to actually mention what arguments a logger accepts. String? Object? Either? What about multiple parameters? What's the expected output when you send different parameters?
The text was updated successfully, but these errors were encountered: