Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject error of pushgateway #1780 #1809

Closed
wants to merge 1 commit into from
Closed

fix: inject error of pushgateway #1780 #1809

wants to merge 1 commit into from

Conversation

Terencesun
Copy link
Contributor

Hi,
Pushgateway is not working, because the unit test did cover the situation about the inject process in another provider


fix the unit test and export the pushgateway in the PrometheusModule

@willsoto
Copy link
Owner

@Terencesun Nice! Great work producing a test case too. This makes sense to me. Do you mind giving me permission to push changes to your fork? Just a couple of code clean-up things I'd like to add.

@Terencesun
Copy link
Contributor Author

@willsoto Hi, I had Invited u to the fork, and u can change the code

@willsoto willsoto closed this in 64cc5ae Jul 14, 2023
willsoto pushed a commit that referenced this pull request Jul 14, 2023
## [5.2.1](v5.2.0...v5.2.1) (2023-07-14)

### Bug Fixes

* pushgateway injection ([#1810](#1810)) ([64cc5ae](64cc5ae)), closes [#1780](#1780) [#1809](#1809)
@willsoto
Copy link
Owner

🎉 This issue has been resolved in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants