fix(controller): removes response.send from route handler

[lastikas]

Calling response.send in the controller prevents interceptos from being able to modify the response object further down the line like, for example, setting headers

It's important to notice that a custom controller that extends the PrometheusController in the same manner as the one in the spec will stop working after this modification

This should be easy to test with a simple interceptor

@Injectable()
export class CustomInterceptor implements NestInterceptor {
  intercept(context: ExecutionContext, next: CallHandler): Observable<any> {
    const res = context.switchToHttp().getResponse<Response>();
    return next.handle().pipe(
      tap(() => {
        res.setHeader('x-test', 'test');
      }),
    );
  }
}

[willsoto]

Thanks. This seems reasonable enough.

One question regarding this:

It's important to notice that a custom controller that extends the PrometheusController in the same manner as the one in the spec will stop working after this modification

Would you consider this a breaking change then?

[lastikas]

Would you consider this a breaking change then?

Yes, this is a breaking change

I can see some projects that would suffer from this here: https://github.com/search?q=extends+PrometheusController&type=Code

[willsoto]

And what would be the upgrade path for users? I'd like to document the breaking change and explain how to fix it.

[lastikas]

And what would be the upgrade path for users? I'd like to document the breaking change and explain how to fix it.

On that note I've just added a modification to the README as well

Basically anyone who extends the Controller and uses await super.index(response); should instead use return super.index(response);

[willsoto]

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀