Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must tap twice to delete a phrase #565

Open
cinadia opened this issue Jun 7, 2024 · 2 comments · May be fixed by #580
Open

Must tap twice to delete a phrase #565

cinadia opened this issue Jun 7, 2024 · 2 comments · May be fixed by #580
Assignees
@cinadia
Labels
bug Something isn't working

Comments

@cinadia
Copy link
Contributor

cinadia commented Jun 7, 2024

Describe the bug
The user must tap twice on the trashcan icon to delete a phrase from a category in settings.

To Reproduce

  1. Navigate to Settings > Categories and Phrases > Tap on any category > Edit Phrases
  2. Tap the trash icon once to delete a phrase

Expected behavior
The delete popup shows up immediately

Actual Behavior
Nothing happens until the user taps the trash icon again

Smartphone (please complete the following information):

  • Device: [e.g. Pixel 4]
  • OS: [e.g. Android 10]
@cinadia cinadia added the bug Something isn't working label Jun 7, 2024
@cinadia cinadia self-assigned this Jun 7, 2024
@github-project-automation github-project-automation bot moved this to Ready to select in Vocable-Android Jun 7, 2024
@kaffn8ed27
Copy link
Collaborator

@cinadia I was not able to reproduce this issue on a variety of emulators & real devices - got any more info on how you found it?

@cinadia
Copy link
Contributor Author

cinadia commented Jul 16, 2024

@cinadia I was not able to reproduce this issue on a variety of emulators & real devices - got any more info on how you found it?

Hey! I just tried it out and I also wasn't able to reproduce it. Looks like it may have gotten fixed as a byproduct of some other change. I was previously able to get it on my Android 13 pixel 4

imbeyondboredom added a commit that referenced this issue Nov 22, 2024
@imbeyondboredom
Fix delete phrase bug (#565)
af0c4de 
Maybe fixes #565?
Do not merge without testing. This is AI generated.

Add methods to delete phrases from categories.

* **CustomCategoryPhraseViewModel.kt**
  - Add `deletePhraseFromCategory` method to delete a phrase from a category.
* **EditCategoryPhrasesViewModel.kt**
  - Add `deletePhrase` method to delete a phrase from a category.
  - Update constructor to make `phrasesUseCase` a private property.
@imbeyondboredom imbeyondboredom linked a pull request Nov 22, 2024 that will close this issue
Open
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cinadia cinadia

Labels
bug Something isn't working
Projects
Vocable-Android
Status: Ready to select
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix delete phrase bug (#565) willowtreeapps/vocable-android
2 participants
@kaffn8ed27 @cinadia