Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all options of AMQPStreamConnection #4

Open
mirfilip opened this issue Feb 9, 2017 · 1 comment
Open

Support all options of AMQPStreamConnection #4

mirfilip opened this issue Feb 9, 2017 · 1 comment

Comments

@mirfilip
Copy link

mirfilip commented Feb 9, 2017

RabbitServiceProvider acts as a wrapper/factory that is responsible for preparing either AMQPStreamConnection or AMQPLazyConnection.

Currently, only: host, port, user, password, vhost are passed to the constructor. If you define any other config keys that are supported by php-amqplib, they'll just be ignored.

This is especially painful if you want to customize timeouts, heartbeat or keepalive. These are construction-time variables and cannot be changed after connection object creation.

Also, the only required arguments for constructing AMQPStreamConnection are: host, port, user, password. vhost is / by default. Yet, you need to define it in config or you get array access errors. Yes, a little nitpick ;)

This library should really pass all the options if it wants to be a good wrapper.

@williamespindola
Copy link
Owner

Hi @mirfilip so you can help to do this with some PRs and issues. Where can we start?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants