Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove "twinkle" and "friendly" from module names #1974

Closed
NovemLinguae opened this issue Jun 22, 2024 · 4 comments · May be fixed by #1977
Closed

remove "twinkle" and "friendly" from module names #1974

NovemLinguae opened this issue Jun 22, 2024 · 4 comments · May be fixed by #1977

Comments

@NovemLinguae
Copy link
Member

NovemLinguae commented Jun 22, 2024 •
edited
Loading

  • overly verbose
  • makes alphabetizing difficult

Should probably work on and merge this patch after clearing out the PR queue, to avoid a bunch of merge conflicts.

image
@nardog
Copy link
Contributor

nardog commented Jun 22, 2024

While you're at it, consider renaming "fluff" too, I've found it confusing and opaque.

@NovemLinguae
Copy link
Member Author

Note to self: scripts/draftRelease.sh, scripts/sync.pl, and MediaWiki:Gadgets-definition contain lists of Twinkle files that will need to be updated.

NovemLinguae added a commit to NovemLinguae/twinkle that referenced this issue Jun 22, 2024
@NovemLinguae
rename twinklefluff.js to twinklerollback.js
1bc5493 
fixes wikimedia-gadgets#1974

- Did an all repo, case sensitive search and replace of Twinkle.fluff -> Twinkle.rollback
- Did an all repo search for "fluff" and changed remaining results to "rollback"

IMPORTANT: requires modifying https://test.wikipedia.org/wiki/MediaWiki:Gadgets-definition and https://en.wikipedia.org/wiki/MediaWiki:Gadgets-definition

IMPORTANT: may also require creating/renaming "Module: rollback" tag in the GitHub issue tracker, so that the PR labeler doesn't break

Because of the gadget definition file changes, should be careful with this one. May want to do a deploy to testwiki before deploying to enwiki.

Note to self: I haven't manually tested this yet. Manually test it before merging.
@NovemLinguae NovemLinguae mentioned this issue Jun 22, 2024
Open
@NovemLinguae
Copy link
Member Author

I think I've changed my mind about this ticket. Removing "twinkle" from the beginning of the module names would make CirrusSearch search suggestions worse, and would break the convention of prefixing gadget files with the name of the gadget.

image

Perhaps I will re-scope this ticket to rename "friendly" to "twinkle".

This was referenced Aug 22, 2024
Closed
Open
@NovemLinguae
Copy link
Member Author

Closing in favor of #1995

@NovemLinguae NovemLinguae closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename twinklefluff.js to twinklerollback.js NovemLinguae/twinkle
2 participants
@nardog @NovemLinguae