Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip of CD fails to set "Various Artists" flac tag #518

Closed
Emersont1 opened this issue Dec 11, 2020 · 2 comments
Closed

Rip of CD fails to set "Various Artists" flac tag #518

Emersont1 opened this issue Dec 11, 2020 · 2 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Milestone

Comments

@Emersont1
Copy link
Contributor

Hi, I'm trying to rip the following CD https://musicbrainz.org/release/d8506058-70bd-4985-974f-df4319114c70 which has various artists on MusicBrainz. When it is ripped, Various Artists appear in the folder name, but not in the FLAC's metadata

Running on Arch Linux x64, installed from community repo

@github-actions
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@Emersont1
Copy link
Contributor Author

I've done some looking, and I'm not sure if this is an intended feature of the project as this can be trivially fixed by modifying the code here to the following

if self.metadata and not self.metadata.various:
tags['ALBUMARTIST'] = releaseArtist

        if self.metadata:
            if self.metadata.various:
                tags['ALBUMARTIST'] = "Various Artists"
            else:
                tags['ALBUMARTIST'] = releaseArtist

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels labels Dec 25, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Projects
None yet
Development

No branches or pull requests

2 participants