From c9c56ee179a961bc7254e82bc2a38dfcd7f4c683 Mon Sep 17 00:00:00 2001 From: Jeremy Roman Date: Mon, 29 Jan 2024 10:48:46 -0500 Subject: [PATCH] Do not initialize a URLPatternInit member to null in "initialize a URLPattern" It is not valid for the baseURL dictionary member to be null, only either absent or a USVString. Instead, this should be omitted from the dictionary altogether if no string was provided to this algorithm. Any string which is invalid will fail later on, when it is to be parsed as a URL. Fixes #204. --- spec.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec.bs b/spec.bs index 27c3a57..a3224a6 100644 --- a/spec.bs +++ b/spec.bs @@ -354,7 +354,7 @@ Each {{URLPattern}} object has an associated hash component< 1. If |input| is a [=scalar value string=] then: 1. Set |init| to the result of running [=parse a constructor string=] given |input|. 1. If |baseURL| is null and |init|["{{URLPatternInit/protocol}}"] does not [=map/exist=], then throw a {{TypeError}}. - 1. Set |init|["{{URLPatternInit/baseURL}}"] to |baseURL|. + 1. If |baseURL| is not null, [=map/set=] |init|["{{URLPatternInit/baseURL}}"] to |baseURL|. 1. Otherwise: 1. [=Assert=]: |input| is a {{URLPatternInit}}. 1. If |baseURL| is not null, then throw a {{TypeError}}.