Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linker performance tuning, round 1 #14

Open
mighdoll opened this issue Oct 16, 2024 · 2 comments
Open

linker performance tuning, round 1 #14

mighdoll opened this issue Oct 16, 2024 · 2 comments
Milestone

Comments

@mighdoll
Copy link
Contributor

Check to see if there's any obvious performance gotchas in the linker.

@github-project-automation github-project-automation bot moved this to Unprioritized in wesl-js Oct 16, 2024
@mighdoll mighdoll added this to the M1 milestone Nov 18, 2024
@stefnotch
Copy link
Contributor

I could update the bench to have a mode where the entire linker is executed. Would that do the trick?

@mighdoll
Copy link
Contributor Author

The thought here was for a quick perf review in the M1 timeframe. @stefnotch has already improved the perf quite a bit at the parsing layer, but the other parts of the linker are unexamined perf wise.

I was thinking roughly:
. collect 1-2 realistic larger shader projects as test cases (e.g. perhaps a bevy subset and one other project)
. run with performance sampling (e.g. via bench --profile), (extended to link() as you suggest!). node performance should be close enough to the browser for this test.
. also test a minified production build to see that it tracks proportionally

and fix any silly perf wins easily available.

Marking as M1+.

@mighdoll mighdoll modified the milestones: M1, M1+ Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants