Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify notebook results #599

Closed
Zarquan opened this issue Dec 5, 2021 · 3 comments
Closed

Verify notebook results #599

Zarquan opened this issue Dec 5, 2021 · 3 comments
Assignees
@stvoutsin
Labels
aglais-testing bug Something isn't working high priority For urgent issues to be worked on before others where possible

Comments

@Zarquan
Copy link
Collaborator

Zarquan commented Dec 5, 2021

Link to the issue in the aglais-testing project.
wfau/aglais-testing#17

In recent tests there was an issue with matplotlib and none of the tests generated any plots. However, all the tests passed.
Bumped this to high priority because the tests said all was OK when it wasn't.
@Zarquan Zarquan added bug Something isn't working high priority For urgent issues to be worked on before others where possible labels Dec 5, 2021
@Zarquan
Copy link
Collaborator Author

Zarquan commented Jan 4, 2022

To be clear - the issue isn't the missing matplotlib library. this issue is that the test passed when even though the notebooks failed to generate any graphs.

The test system needs to verify that the results of the notebooks are correct.

@Zarquan
Copy link
Collaborator Author

Zarquan commented Mar 8, 2022

I think this is done in PR #645 ?

@Zarquan
Copy link
Collaborator Author

Zarquan commented Jul 25, 2022

Done

@Zarquan Zarquan closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stvoutsin stvoutsin

Labels
aglais-testing bug Something isn't working high priority For urgent issues to be worked on before others where possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zarquan @stvoutsin