Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/36 consolidate delete behaviour #53

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feature/36 consolidate delete behaviour #53

wants to merge 9 commits into from

Conversation

achilles-portarinos
Copy link

  • consolidate delete behaviour: Precise deletions (by id and/or partition key) throw. Imprecise (predicate) return number of deleted items.
  • implement soft-delete
  • add tests for soft-delete
  • update XML comments in IDatabaseRepository
  • move GetAsync(predicate) to QuerySingleAsync(predicate) and ensure single result

@achilles-portarinos achilles-portarinos linked an issue Nov 30, 2022 that may be closed by this pull request
DeleteAsync behaves inconsistently #36
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianKuesters SebastianKuesters Awaiting requested review from SebastianKuesters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeleteAsync behaves inconsistently
1 participant
@achilles-portarinos