Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netty 4 transport module #16

Closed
qdaxb opened this issue Apr 26, 2016 · 8 comments
Closed

Add netty 4 transport module #16

qdaxb opened this issue Apr 26, 2016 · 8 comments

Comments

@qdaxb
Copy link
Collaborator

qdaxb commented Apr 26, 2016

Netty 3 is TOO old, we should add a module for netty 4.

@ccc-rrr
Copy link

ccc-rrr commented Apr 26, 2016

一些其它的三方库也可以考虑升级到最新,比如log4j2(还能配合disruptor)代替log4j,zkclient,Commons Pool2等等。
motan-springsupport/pom.xml里的spring-web还是3.2.3.RELEASE,demo里用的倒是4.2.4.RELEASE。
能否“motan-springsupport”改为"motan-spring-support",和其他的模块不一致呢。

@qdaxb
Copy link
Collaborator Author

qdaxb commented Apr 26, 2016

@ccc-rrr 感谢建议。

其它第三方库我们会考虑在有需要的时候升级,log4j的依赖我们未来考虑尽量使用slf4j管理而不关心具体实现,其它依赖目前没有具体升级计划。

spring-web里的依赖已经提了pr #18 修复。

motan-springsupport是一个独立模块,这个名字应该不会改。

@simpleSOA
Copy link

以后起码要三方模块要考虑升级下,有些包太老了

@sumory
Copy link
Contributor

sumory commented Apr 28, 2016

Netty4支持大概会什么时候放出来?

@qdaxb
Copy link
Collaborator Author

qdaxb commented Apr 28, 2016

@simpleSOA 目前我们没有遇到依赖版本太老导致的问题,如果觉得哪个依赖急需升级可以提issue或pr。

@sumory netty4的支持还在规划中,可能要过上一段时间。

@ghost
Copy link

ghost commented Apr 29, 2016

log4j2自己可以添加支持,只需要在maven中把自带的log相关的jar排除,并增加log4j2相关的实现即可
<dependency> <groupId>com.weibo</groupId> <artifactId>motan-registry-zookeeper</artifactId> <version>${motan.version}</version> <exclusions> <exclusion> <groupId>org.slf4j</groupId> <artifactId>slf4j-api</artifactId> </exclusion> <exclusion> <groupId>org.slf4j</groupId> <artifactId>slf4j-log4j12</artifactId> </exclusion> </exclusions> </dependency>

@ghost
Copy link

ghost commented May 2, 2016

“log4j的依赖我们未来考虑尽量使用slf4j管理而不关心具体实现” 这个设计思路是对的。

@louyuting
Copy link

加入netty4的支持,有没有有这个想法的?现在在实施吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants