Distribute config file from primary location #739
Conversation
ethanwhite
force-pushed
the
one-config-to-rule-them-all
branch
from
fbf2f66 to
21276f6
Compare
ethanwhite
changed the title
|
This is currently broken because we're not actually testing against the installed package, we're testing against the source code, which doesn't have the data included. This is part of the same problem as #562. I'm going to open an issue to discuss the general solution |
|
This relates to a broader conversation that I would love to move to hydra, add argparse support for config. This is a 2.0 kinda thing, there may be a more short term patch here for the immediate need. |
|
Resolved by our move to |
|
Actually there's probably some cleanup in here that is still worth including so reopening to check if it still needs to be added |
ethanwhite
force-pushed
the
one-config-to-rule-them-all
branch
from
21276f6 to
3cf3921
Compare
ethanwhite
changed the title
ethanwhite
force-pushed
the
one-config-to-rule-them-all
branch
3 times, most recently
from
eb172bb to
2ab40b0
Compare
|
@bw4sz & @henrykironde - this should finally complete our move to |
|
And @henrykironde - once this is merged lets go ahead and roll a new release. |
We had two copies of deepforest_config.yml. The first was the main copy in the root directory of the repo. The second was a copy that got distributed with the package. This is error prone and unnecessary since we can package directly from a single file. Since it makes sense for this file to be exposed at the top level in src/deepforest this puts the canonical file in that location the removes other files. Also requires updating some tests to make sure they are getting the config file from the package itself not the working directory. Closes weecology#531
ethanwhite
force-pushed
the
one-config-to-rule-them-all
branch
from
2ab40b0 to
ed03835
Compare
|
I've rebased this again. @henrykironde can we please get this merged once the tests pass and roll a new release. |
We had two copies of deepforest_config.yml. The first was the main copy in the root directory of the repo. The second was a copy that got distributed with the package. This is error prone and unnecessary since we can package directly from the root file. We had some infrastructure to ensure these were the same, but that was removed as part of moving to the
src/deepforeststructure. This revived PR finishes the job by remove the extra copy and directly packaging the copy in the root directory.Closes #531. Fixes #881 (again).