Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一些细节错误 #73

Closed
cnjack opened this issue Sep 4, 2019 · 8 comments
Closed

一些细节错误 #73

cnjack opened this issue Sep 4, 2019 · 8 comments
Labels
bug Something isn't working fixed Issue already fixed

Comments

@cnjack
Copy link

cnjack commented Sep 4, 2019

lib.wx.api.d.ts
SocketTaskOnErrorCallbackResult
应该定义为

interface WebScoketCloseCallbackResult {
    code: number;
    reason: string;
}

SocketTask
应该加上

readyState: SocketStatus;

并附上

enum SocketStatus {
    CONNECTING,
    OPEN,
    CLOSING,
    CLOSED
}
@wechat-miniprogram-admin
Copy link
Contributor

这个 文档 里也没有,我们确认一下。

@cnjack
Copy link
Author

cnjack commented Sep 6, 2019

好的 我console打印了下看到的😜

@cnjack
Copy link
Author

cnjack commented Sep 11, 2019

@wechat-miniprogram-admin 亲啥时候可以处理一下呀

@cnjack
Copy link
Author

cnjack commented Sep 16, 2019

@wechat-miniprogram-admin @SgLy 如何了呀 我的一个库依赖这个issue呀 我现在在本地做了link 还是希望可以fix一下呀

@wechat-miniprogram-admin
Copy link
Contributor

这边确认了一下,这个 readyState 没有在文档上是因为目前是内部使用,所以我们也不保证它正确以及长期可用的,因此就不加到定义里了。如果要使用的话可以像 这样 补充到自己的定义里,不过我们是不建议使用的~

@cnjack
Copy link
Author

cnjack commented Sep 17, 2019

onclose 的 response? WebScoketCloseCallbackResult 这个文档是有问题的

@wechat-miniprogram-admin
Copy link
Contributor

code 和 reason 这个应该是漏了,之后补上

@wechat-miniprogram-admin wechat-miniprogram-admin added bug Something isn't working fix in next version Issue will be solved in next version labels Sep 17, 2019
@cnjack
Copy link
Author

cnjack commented Sep 17, 2019

谢谢大佬~

@wechat-miniprogram-admin wechat-miniprogram-admin added fixed Issue already fixed and removed fix in next version Issue will be solved in next version labels Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue already fixed
Projects
None yet
Development

No branches or pull requests

2 participants