From 373046710b80716d55058f418f3f9925d4b3a842 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Sun, 12 Apr 2020 14:08:20 +0200 Subject: [PATCH] [test] Do not call `duplex.end()` prematurely Keep the `WebSocket` connection open while the test is run. Refs: https://github.com/nodejs/node/pull/32780 --- test/create-websocket-stream.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/create-websocket-stream.test.js b/test/create-websocket-stream.test.js index 19a23e471..fa03c4096 100644 --- a/test/create-websocket-stream.test.js +++ b/test/create-websocket-stream.test.js @@ -414,6 +414,7 @@ describe('createWebSocketStream', () => { ws._receiver.on('drain', () => { called.push('drain'); assert.ok(!ws._socket.isPaused()); + duplex.end(); }); const list = Sender.frame(randomBytes(16 * 1024), { @@ -429,7 +430,6 @@ describe('createWebSocketStream', () => { ws._socket.push(Buffer.concat(list)); }); - duplex.on('resume', duplex.end); duplex.on('close', () => { assert.deepStrictEqual(called, ['read', 'drain']); wss.close(done); @@ -450,6 +450,7 @@ describe('createWebSocketStream', () => { assert.ok(!ws._receiver._writableState.needDrain); read(); assert.ok(!ws._socket.isPaused()); + duplex.end(); }; ws.on('open', () => { @@ -470,7 +471,6 @@ describe('createWebSocketStream', () => { ws._socket.push(Buffer.concat(list)); }); - duplex.on('resume', duplex.end); duplex.on('close', () => { assert.deepStrictEqual(called, ['drain', 'read']); wss.close(done);