Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize non-GET URLs with native JSON values #859

Closed
tw4l opened this issue Jul 26, 2023 · 1 comment · Fixed by #893
Closed

Canonicalize non-GET URLs with native JSON values #859

tw4l opened this issue Jul 26, 2023 · 1 comment · Fixed by #893
Assignees

Comments

@tw4l
Copy link
Member

tw4l commented Jul 26, 2023

The way that pywb rewrites URLs for POST (and other non-GET) request canonicalization ends up writing Pythonic values into the URL such as True, False, and None, whereas we ideally want to have it use valid JSON values.

This is part of making POST canonicalization consistent across Webrecorder tools. Related to webrecorder/specs#141

@tw4l tw4l self-assigned this Jul 26, 2023
@tw4l tw4l moved this from Triage to Design In Progress in Webrecorder Projects Jul 26, 2023
@tw4l tw4l moved this from Design In Progress to Ready for Dev in Webrecorder Projects Jul 26, 2023
@tw4l
Copy link
Member Author

tw4l commented Jul 26, 2023

We will also need to ensure that the fuzzy matching in pywb and wabac.js works with previously-created URLs created by pwyb, or develop a process to reindex as necessary.

@tw4l tw4l moved this from Ready for Dev to Dev In Progress in Webrecorder Projects Jul 27, 2023
@tw4l tw4l moved this from Dev In Progress to Ready for Dev in Webrecorder Projects Jul 27, 2023
@tw4l tw4l moved this from Ready to Implementing in Webrecorder Projects Apr 1, 2024
@tw4l tw4l moved this from Implementing to In Review in Webrecorder Projects Apr 4, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

2 participants