Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update references to org public profile -> gallery #2330

Merged
merged 15 commits into from
Jan 27, 2025
Merged

feat: Update references to org public profile -> gallery #2330

merged 15 commits into from
Jan 27, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jan 22, 2025 •
edited
Loading

Resolves #2329

Changes

  • Renames public URL prefix to explore
  • Updates org settings sections
  • Removes or renames references to "org profile"

Manual testing

  1. Log in as org admin
  2. Go to org settings
  3. Regression test org settings, verifying that public page still works as expected

Screenshots

Page Image/video
Org Settings Screenshot 2025-01-21 at 8 52 10 PM
User guide Screenshot 2025-01-21 at 9 07 08 PM

@SuaYoo SuaYoo marked this pull request as ready for review January 22, 2025 02:28
@SuaYoo
Copy link
Member Author

SuaYoo commented Jan 22, 2025

Putting back into draft to look into feasibility of combining the sections, per Discord thread

@SuaYoo SuaYoo marked this pull request as draft January 22, 2025 03:26
@SuaYoo SuaYoo marked this pull request as ready for review January 22, 2025 05:08
@Shrinks99
Copy link
Member

Shrinks99 commented Jan 22, 2025 •
edited
Loading

Mostly looks good to me! Any big reason for swapping the control to the other side of the window? Seems like we could use the same column layout with the help text on the right? Labels all look good!

@SuaYoo
Copy link
Member Author

SuaYoo commented Jan 22, 2025

Any big reason for swapping the control to the other side of the window?

I copied the pattern for the account settings toggle, which updates immediately on toggle (rather than a save button)--but don't feel strongly if we want to add back the save button?

@ikreymer ikreymer added this to the Public Collections milestone Jan 22, 2025
@ikreymer ikreymer self-requested a review January 26, 2025 01:22
@ikreymer
Copy link
Member

Yeah, on second thought, the toggle all the way on the right was slightly confusing, as I was expecting it to be on the left and not with help text. Could still make it be instant, but I think keeping it on the left looks better...

Any big reason for swapping the control to the other side of the window?

I copied the pattern for the account settings toggle, which updates immediately on toggle (rather than a save button)--but don't feel strongly if we want to add back the save button?

Shrinks99
Shrinks99 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A couple of minor suggestions, good to go from me! I like gallery.

frontend/docs/docs/user-guide/org-settings.md Outdated Show resolved Hide resolved
frontend/src/pages/org/settings/components/visibility.ts Outdated Show resolved Hide resolved
frontend/src/pages/org/dashboard.ts Outdated Show resolved Hide resolved
@SuaYoo SuaYoo changed the title feat: Update references to org public profile -> page feat: Update references to org public profile -> gallery Jan 27, 2025
SuaYoo and others added 2 commits January 27, 2025 12:33
@SuaYoo
update icon
623960a
@SuaYoo @Shrinks99
Apply suggestions from code review
bc4840a 
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
@SuaYoo SuaYoo merged commit 3c86077 into main Jan 27, 2025
27 checks passed
@SuaYoo SuaYoo deleted the frontend-update-public-url-prefix branch January 27, 2025 21:48
Shrinks99 added a commit that referenced this pull request Jan 28, 2025
@SuaYoo @ikreymer @Shrinks99
feat: Update references to org public profile -> gallery (#2330)
0d44576 
- Renames public URL prefix to `explore`
- Updates org settings sections
- Removes or renames references to "org profile"

---------

Co-authored-by: Ilya Kreymer <ikreymer@gmail.com>
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
emma-sg pushed a commit that referenced this pull request Jan 29, 2025
@SuaYoo @ikreymer
@Shrinks99 @emma-sg
feat: Update references to org public profile -> gallery (#2330)
695d87e 
- Renames public URL prefix to `explore`
- Updates org settings sections
- Removes or renames references to "org profile"

---------

Co-authored-by: Ilya Kreymer <ikreymer@gmail.com>
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
emma-sg pushed a commit that referenced this pull request Jan 29, 2025
@SuaYoo @ikreymer
@Shrinks99 @emma-sg
feat: Update references to org public profile -> gallery (#2330)
1e2a590 
- Renames public URL prefix to `explore`
- Updates org settings sections
- Removes or renames references to "org profile"

---------

Co-authored-by: Ilya Kreymer <ikreymer@gmail.com>
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
emma-sg pushed a commit that referenced this pull request Jan 29, 2025
@SuaYoo @ikreymer
@Shrinks99 @emma-sg
feat: Update references to org public profile -> gallery (#2330)
d18339d 
- Renames public URL prefix to `explore`
- Updates org settings sections
- Removes or renames references to "org profile"

---------

Co-authored-by: Ilya Kreymer <ikreymer@gmail.com>
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shrinks99 Shrinks99 Shrinks99 approved these changes

@ikreymer ikreymer ikreymer approved these changes

@emma-sg emma-sg Awaiting requested review from emma-sg

@tw4l tw4l Awaiting requested review from tw4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Public Collections
Development

Successfully merging this pull request may close these issues.

Update public view URL prefix
3 participants
@SuaYoo @Shrinks99 @ikreymer