🐛 Knip doesn't report @types packages as unused when types are bundled

[nihalgonsalves]

Prerequisites

• I'm using the latest version
• I've read the relevant documentation
• I've searched for existing issues
• I've checked the list of known issues
• I've read the issue reproduction guide

Reproduction url

https://stackblitz.com/edit/github-rr55fg3x?file=package.json,index.ts

Reproduction access

• I've made sure the reproduction is publicly accessible

Description of the issue

(I initially reported this as a feature request in #936)

https://knip.dev/guides/handling-issues#type-definition-packages implies that these should be reported as unused, but I cannot get Knip to report them. I tried a package from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/notNeededPackages.json and a package that initially prompted me to file the first issue:

  "devDependencies": {
    "@types/ajv": "^0.0.5",
    "@types/eslint__js": "^8.42.3",
    "knip": "^5.43.6"
  },
  "dependencies": {
    "@eslint/js": "^9.20.0",
    "ajv": "^8.17.1"
  }

Assuming the dependencies are used somewhere, I'd expect the @types/ packages to be reported as unused, as both packages bundle their types ^{1 2}

Footnotes

1. https://github.com/ajv-validator/ajv/blob/master/package.json#L6 ↩

2. https://github.com/eslint/eslint/blob/main/packages/js/package.json#L6 ↩

[webpro]

Thanks for the report and the report, @nihalgonsalves. Applied some fixes and did some smoke testing, things look better now. Any chance you could give it a shot on one ore more of your project(s)? You could install like so:

npm i -D https://pkg.pr.new/knip@fc95526

It's interesting how it seems to catch some unused dependencies already: https://github.com/webpro-nl/knip/actions/runs/13290036970

[nihalgonsalves]

yup seems to work now, thank you! tried it on this commit~1: nihalgonsalves/esconfig@0855254

Unused devDependencies (1)
@types/eslint__js  package.json:36:6

[webpro]

🚀 This issue has been resolved in v5.44.1. See Release 5.44.1 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

[webpro]

Thanks again Nihal! LFG 🚀