feat: overlay displays unhandled promise rejection

[malcolm-kee]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

overlay.runtimeErrors should capture unhandled Promise rejection, as it's still runtime error, just async in nature.

Breaking Changes

Not breaking change.

Additional Info

Part of #3689

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (51f8a1b) 91.96% compared to head (f9fe3d2) 91.84%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4849      +/-   ##
==========================================
- Coverage   91.96%   91.84%   -0.12%     
==========================================
  Files          16       16              
  Lines        1704     1704              
  Branches      647      647              
==========================================
- Hits         1567     1565       -2     
- Misses        126      128       +2     
  Partials       11       11              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[yoyo837]

How do I make unhandled promise rejection not overlay displays, so that it behaves the same as before.

[yoyo837]

How do I make unhandled promise rejection not overlay displays, so that it behaves the same as before.

overlay: {
++runtimeErrors: false,
  errors: true,
  warnings: false,
},

This is the same behavior as before.

[keremcanb]

This feature gave us so much headache that we had to downgrade to the previous version.

[alexander-akait]

@keremcanb just disable it using options

[keremcanb]

We are running on CRA, which is not ejected. Also we don't want to disable all runtime error messages.

…

On Wed, May 31, 2023, 21:58 Alexander Akait ***@***.***> wrote: @keremcanb <https://github.com/keremcanb> just disable it using options — Reply to this email directly, view it on GitHub <#4849 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOTCKFLRXSYOV22F7ZKVAKTXI5MB5ANCNFSM6AAAAAAXYT23FA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[alexander-akait]

You can filter them, sorry we will not remove this feature

[tomasztomys]

It should be break change!