Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace ansi-html with ansi-html-community #4011

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix: replace ansi-html with ansi-html-community #4011

merged 1 commit into from
Nov 8, 2021

Conversation

G-Rath
Copy link

@G-Rath G-Rath commented Nov 7, 2021

This fixes the ReDoS vulnerability CVE-2021-23424 & #3929

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No, since this is swapping out a library so the existing tests should cover the change.

Motivation / Use-Case

Resolves a security vulnerability.

Breaking Changes

None

Additional Info

Closes #3813

@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (v3@5cb545f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             v3    #4011   +/-   ##
=====================================
  Coverage      ?   93.47%           
=====================================
  Files         ?       34           
  Lines         ?     1333           
  Branches      ?      381           
=====================================
  Hits          ?     1246           
  Misses        ?       85           
  Partials      ?        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb545f...ba2d6f6. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants