Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion[init]: inform user for deps which will be added after init. #982

Closed
pranshuchittora opened this issue Jul 4, 2019 · 0 comments

Comments

@pranshuchittora
Copy link
Member

Describe the bug

  • After running init with these options
? Will you use one of the below JS solutions? No
? Will you use one of the below CSS solutions? No

The following deps gets installed.

 "devDependencies": {
    "babel-plugin-syntax-dynamic-import": "^6.18.0",
    "html-webpack-plugin": "^3.2.0",
    "terser-webpack-plugin": "^1.3.0",
    "webpack": "^4.35.2",
    "webpack-dev-server": "^3.7.2",
    "workbox-webpack-plugin": "^4.3.1"
  }

A user might not require these deps, hence the user must be informed before proceeding further.

What is the current behavior?

This is where you elaborate on the current behavior of the cli, how it behaves normally differing from the previous version/build you did.

To Reproduce
Steps to reproduce the behavior:

  1. Run inti
  2. Check the package.json

Expected behavior
Ask/inform the user regarding the dependencies that that going to be installed. before installing

Let's discuss 📢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants