Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[infra]: weird behaviour by commit hook #956

Closed
pranshuchittora opened this issue Jun 11, 2019 · 6 comments · Fixed by #973
Closed

🐞[infra]: weird behaviour by commit hook #956

pranshuchittora opened this issue Jun 11, 2019 · 6 comments · Fixed by #973

Comments

@pranshuchittora
Copy link
Member

Describe the bug
After commit, the code gets automatically formatted and linting throws an error in weird characters.

What is the current behavior?
Error and bad linting.

To Reproduce
Steps to reproduce the behavior:

  1. I changed a few .ts files and after doing git commit
  2. FIles gets automatically formatted
  3. Running yarn lint throws error because of bad auto linting.
  4. See error

Expected behavior
No formatting after commit

Screenshots

Screenshot from 2019-06-11 14-57-02

@anikethsaha
Copy link
Member

that's the prettier-eslint pkg, you can remove the --write flag from the npm scripts of format,

@evenstensberg
Copy link
Member

This needs to be fixed, feel free to send a PR

@anshumanv
Copy link
Member

This is because of the prettier config and eslint config being conflicting for some reason, would encourage to explore the properties which are conflicting and then only enabling one of them. Would also make #938 easy to solve

@jamesgeorge007
Copy link
Member

@evenstensberg I shall go ahead if this is still open to be worked on 👏

@evenstensberg
Copy link
Member

Go for it!

@ematipico
Copy link
Contributor

ematipico commented Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants