Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Init] the command should add the chosen libs into devDep #431

Closed
ematipico opened this issue May 4, 2018 · 5 comments
Closed

[Init] the command should add the chosen libs into devDep #431

ematipico opened this issue May 4, 2018 · 5 comments

Comments

@ematipico
Copy link
Contributor

Do you want to request a feature or report a bug?

Bug

What is the current behavior?
The init command add the chosen libraries inside the dependencies section of the package.json

If the current behavior is a bug, please provide the steps to reproduce.

  • Run the init command
  • Answer few questions, make sure to choose something like sass loader, for instance
  • Check the package.json

What is the expected behavior?
It should add them inside the devDependencies of the package.json

@evenstensberg
Copy link
Member

@ematipico
Copy link
Contributor Author

I tried the package on a project and I saw that the dependencies were installed in the wrong section

@evenstensberg
Copy link
Member

Did you run it from the CLI itself or another project? Could you print your pkg.json?

@ematipico
Copy link
Contributor Author

I ran it through the cli itself.

@evenstensberg
Copy link
Member

I'm able to reproduce this, so yeah, let's fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants