Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output pnpm version with info/version command #3906

Merged
merged 6 commits into from
Aug 21, 2023
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Fixes #3072

Add pnpm information

Does this PR introduce a breaking change?
No

Other information
No

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #3906 (bf2c2df) into master (554aa52) will not change coverage.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3906   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files          22       22           
  Lines        1688     1688           
  Branches      486      486           
=======================================
  Hits         1534     1534           
  Misses        154      154           
Files Changed Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 92.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554aa52...bf2c2df. Read the comment docs.

@evenstensberg
Copy link
Member

Is this still a draft?

@snitin315
Copy link
Member Author

Yeah. I just need to fix the tests on CI, will do it today.

@snitin315 snitin315 marked this pull request as ready for review August 19, 2023 01:35
@snitin315 snitin315 requested a review from a team as a code owner August 19, 2023 01:35
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evenstensberg
Copy link
Member

Could you rebase to make commitlint happy?

@snitin315 snitin315 disabled auto-merge August 21, 2023 03:49
@snitin315
Copy link
Member Author

@evenstensberg I'll modify the commit message while merging the PR, it should be fine.

@snitin315 snitin315 merged commit 38f3c6f into master Aug 21, 2023
@snitin315 snitin315 deleted the feat/pnpm-info branch August 21, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants