Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message for missing default export in configuration #3685

Merged
merged 3 commits into from
Mar 19, 2023

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

No need

Summary

fixes #3684

Does this PR introduce a breaking change?

No

Other information

No

@alexander-akait alexander-akait requested a review from a team as a code owner March 19, 2023 21:43
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #3685 (a408f54) into master (f642f8d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3685      +/-   ##
==========================================
+ Coverage   91.37%   91.38%   +0.01%     
==========================================
  Files          22       22              
  Lines        1588     1591       +3     
  Branches      447      448       +1     
==========================================
+ Hits         1451     1454       +3     
  Misses        137      137              
Impacted Files Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 92.73% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f642f8d...a408f54. Read the comment docs.

@alexander-akait alexander-akait merged commit e0a4a09 into master Mar 19, 2023
@alexander-akait alexander-akait deleted the fix-handle-broken-configurations branch March 19, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'then') when using ESM to export config
2 participants