fix: make define-process-env-node-env alias node-env #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3514 +/- ##
==========================================
+ Coverage 91.36% 91.37% +0.01%
==========================================
Files 22 22
Lines 1586 1588 +2
Branches 446 447 +1
==========================================
+ Hits 1449 1451 +2
Misses 137 137
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Dec 4, 2022
snitin315
approved these changes
Dec 4, 2022
evenstensberg
approved these changes
Dec 4, 2022
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Restores v4's
--node-envCLI flag while preserving the new--define-process-env-node-envflag.Did you add tests for your changes? Yup
If relevant, did you update the documentation? Yup (although depending on what the desired future is for these flags, possibly the web documentation needs to be updated too).
Summary
Fix #3503. Since the full fix discussed in that thread would be breaking, the interim solution is to restore the
--node-envflag and have both--define-process-env-node-envand--node-envdo the same thing. In the future these may diverge as discussed here: #3503 (comment)Does this PR introduce a breaking change?
No. This was very intentionally done in this way to not create a breaking change. It seems unclear as to what the desired long-term behavior is so for now there are two alias commands.
Other information
N/A