Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(init-generator): cleanup #333

Merged
merged 2 commits into from
Mar 11, 2018
Merged

Conversation

dhruvdutt
Copy link
Member

What kind of change does this PR introduce?
Enhancement

Summary
Code cleanup

  • variable names parity
  • let => const
  • shorten code, use ternary operator

Does this PR introduce a breaking change?
No

@dhruvdutt
Copy link
Member Author

dhruvdutt commented Mar 11, 2018

@ev1stensberg I've ran npm run test -u and npm run appveyor:test -- -u both locally and updated the snapshot.
No idea why CI is failing to recognize it.

@evenstensberg
Copy link
Member

Might be cause jscodeshift has some changes in their new version, I'll check it out

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks bud! ❤️

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg
Copy link
Member

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants