Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readFile (windows) #226

Merged
merged 1 commit into from
Mar 15, 2017
Merged

fix: readFile (windows) #226

merged 1 commit into from
Mar 15, 2017

Conversation

Silviu-Marian
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Refactoring (no functional changes, no api changes)

What is the current behavior? (You can also link to an open issue here)
The fix in #208 (#69, #40) didn't work. When creating new files that match the globbing pattern in karma.config, the watcher crashes and needs a manual restart.

What is the new behavior?
Watcher doesn't crash when creating new files :)

Does this PR introduce a breaking change?

  • No

Other information:
In continuation to #225 :)
Tried to wrap my head around the contributing guide, but ran into problems. If you need me to update anything please let me know.

@joshwiens joshwiens changed the title fixed the problem fix: readFile (windows) Feb 25, 2017
@joshwiens joshwiens requested a review from MikaAK February 25, 2017 00:48
@joshwiens joshwiens removed the request for review from MikaAK March 10, 2017 20:16
@joshwiens joshwiens self-assigned this Mar 10, 2017
@joshwiens joshwiens added this to the 2.0.3 milestone Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants