This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
fix(index): use Buffer.from instead of deprecated new Buffer
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Buffer.from(string) instead of deprecated new Buffer(string). Requires Node.js >= 4.5.0, but that seems to fit into current version requirements. Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
|
|
michael-ciniawsky
changed the title
Buffer.from instead of deprecated new Buffer
|
Please sign the CLA :) |
|
Tracking: nodejs/node#19079 |
|
Released in |
This was referenced Mar 3, 2018
Update url-loader in packages/react-scripts from 0.6.2 to 1.0.0
JetBrains/create-react-kotlin-app#76
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Buffer.from(string)instead of deprecatednew Buffer(string).Requires Node.js >= 4.5.0, but that seems to fit into current version requirements.
Refs:
https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor