-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(index): handle chunks
provided as a {Set}
#19
Conversation
chunks
is a Set
in webpack@5chunks
is a Set
(webpack >= v5.0.0
)
Do we need the ( |
@michael-ciniawsky doesn't make sense here, because first webpack versions will be |
chunks
is a Set
(webpack >= v5.0.0
)chunks
provided as a {Set}
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 5 5
Lines 259 259
Branches 101 101
=======================================
Hits 255 255
Misses 4 4
Continue to review full report at Codecov.
|
Thanks to all! |
Is this released yet? |
@bbrzoska no, release planned on next week with some fixes and features |
This PR contains a:
Motivation / Use-Case
In webpack@5,
chunks
is aSet
and thus should be converted to an array.Breaking Changes
n/a
Additional Info
This change makes the plugin compatible with webpack 4 and 5.