-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: esModule option issue fix #476
fix: esModule option issue fix #476
Conversation
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 5 5
Lines 228 228
Branches 96 96
=======================================
Hits 225 225
Misses 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we just create:
const runtimeOptions = { attributes: options.attributes, ... }
here
Line 29 in 6237b59
@evilebottnawi done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR contains a:
Motivation / Use-Case
#475
Breaking Changes
Nope
Additional Info
...