Skip to content

Commit

Permalink
fix(addStyles): support exports of transpiled transforms (`options.tr…
Browse files Browse the repository at this point in the history
…ansform`) (#333)
  • Loading branch information
akki-jat authored and michael-ciniawsky committed Oct 8, 2018
1 parent e821fe8 commit 33aebed
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 1 deletion.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,8 @@ A `transform` is a function that can modify the css just before it is loaded int
This function will be called on the css that is about to be loaded and the return value of the function will be loaded into the page instead of the original css.
If the return value of the `transform` function is falsy, the css will not be loaded into the page at all.

> :Warning: In case you are using ES Module syntax in `tranform.js` then, you **need to transpile** it or otherwise it will throw an `{Error}`.
**webpack.config.js**
```js
{
Expand Down
4 changes: 3 additions & 1 deletion lib/addStyles.js
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,9 @@ function addStyle (obj, options) {

// If a transform function was defined, run it on the css
if (options.transform && obj.css) {
result = options.transform(obj.css);
result = typeof options.transform === 'function'
? options.transform(obj.css)
: options.transform.default(obj.css);

if (result) {
// If transform returns a value, use that instead of the original css.
Expand Down
25 changes: 25 additions & 0 deletions test/basic.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,31 @@ describe("basic tests", function() {

runCompilerTest(expected, done);
});

it("es6 export: should throw error transform is not a function", function(done) {
const transform = require('./transforms/transform_es6');
styleLoaderOptions.transform = 'test/transforms/transform_es6';

// const expectedTansformedStyle = transform(requiredStyle);
const expected = new TypeError('transform is not a function').message;

runCompilerTest(expected, done, function() {
try {
let test = transform(requiredStyle);
} catch(error) {
return error.message;
} });
});

it("es6 export: should not throw any error", function(done) {
const transform = require('./transforms/transform_es6');
styleLoaderOptions.transform = 'test/transforms/transform_es6';

const expectedTansformedStyle = transform[Object.keys(transform)[0]](requiredStyle);
const expected = [existingStyle, expectedTansformedStyle].join("\n");

runCompilerTest(expected, done);
});
});

describe("HMR", function() {
Expand Down
3 changes: 3 additions & 0 deletions test/transforms/transform_es6.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
exports.default = function (css) {
return css.replace('.required', '.transformed');
}

0 comments on commit 33aebed

Please sign in to comment.