Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

...fr/px isn't a valid CSS value. #596

Closed
liubko opened this issue Jul 27, 2018 · 2 comments
Closed

...fr/px isn't a valid CSS value. #596

liubko opened this issue Jul 27, 2018 · 2 comments

Comments

@liubko
Copy link

liubko commented Jul 27, 2018

Deps

"node-sass": "^4.9.2",
"sass-loader": "^7.0.3",

Description

this App.scss file produces such error

// App.scss
$toolbox-width: 220px;
.App {
  grid-template:
    "header  header  header" 48px
    "toolbox content setting" 1fr
    / $toolbox-width 1fr 260px;
}

Error:

[../node_modules/css-loader/index.js?!../node_modules/sass-loader/lib/loader.js?!./src/App.scss] ../node_modules/css-loader??ref--4-oneOf-1-1!../node_modules/sass-loader/lib/loader.js??ref--4-oneOf-1-2!./src/App.scss 308 bytes {main} [built] [failed] [1 error]
    + 1577 hidden modules

ERROR in ./src/App.scss (../node_modules/css-loader??ref--4-oneOf-1-1!../node_modules/sass-loader/lib/loader.js??ref--4-oneOf-1-2!./src/App.scss)
Module build failed (from ../node_modules/sass-loader/lib/loader.js):

    "toolbox content setting" 1fr
                             ^
      0.00455fr/px isn't a valid CSS value.
      in /path/to/my/project/src/App.scss (line 5, column 31)
 @ ./src/App.scss 2:14-157 21:1-42:3 22:19-162
 @ ./src/App.bs.js
 @ ./src/index.bs.js
 @ multi (webpack)-dev-server/client?http://localhost:3000 (webpack)/hot/dev-server.js ./src/index.bs.js

Notes

  1. this compiles without errors
.App {
  grid-template:
    "header  header  header" 48px
    "toolbox content setting" 1fr
    / 220px 1fr 260px;
}
  1. might be related to isn't a valid CSS value - sass-loader can't parse font shorthand options that are 100% valid for css #459
  2. I don't know whether it's related to sass-loader at all..
@alexander-akait
Copy link
Member

@liubko you have invalid sass/scss code, we don't change anything in your code, we just wrapper around node-sass for webpack, if you think what you have valid code and still get error, please create issue in node-sass or sass repo, thanks!

@liubko
Copy link
Author

liubko commented Jul 27, 2018

ok, submitted an issue here sass/libsass#2706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants