perf: use neo-async instead async
#538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
changed the title
neo-async instead asyncneo-async instead async
michael-ciniawsky
approved these changes
Feb 20, 2018
jhnns
requested changes
Feb 21, 2018
package.json
Outdated
| @@ -47,7 +47,8 @@ | |||
| "standard-version": "^4.2.0", | |||
| "style-loader": "^0.18.2", | |||
| "webpack-dev-server": "^2.4.1", | |||
| "webpack-merge": "^4.0.0" | |||
| "webpack-merge": "^4.0.0", | |||
| "webpack": "^3.11.0" | |||
There was a problem hiding this comment.
Why is there a dev dependency on webpack?
There was a problem hiding this comment.
@jhnns need for local tests, remove from PR?
There was a problem hiding this comment.
What's the status here ? :)
There was a problem hiding this comment.
@evilebottnawi Can you remove it for now please ? :)
There was a problem hiding this comment.
@michael-ciniawsky let's do it 👍
alexander-akait
force-pushed
the
feat-use-neo-async
branch
from
cc37c8b
to
a9a3a78
Compare
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 6 6
Lines 117 117
=======================================
Hits 114 114
Misses 3 3
Continue to review full report at Codecov.
|
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 5 (nice to have)
labels
This was referenced Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable ChangesReference: webpack/webpack#6470