Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom npm clients (options.npm) #113

Merged
merged 4 commits into from
Jun 30, 2017

Conversation

lcxfs1991
Copy link
Contributor

some company has their own npm command with a different name ,like tnpm ,cnpm and so on.

@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files           3        3           
  Lines         169      169           
=======================================
  Hits          154      154           
  Misses         15       15
Impacted Files Coverage Δ
src/installer.js 92.94% <100%> (ø) ⬆️
src/plugin.js 89.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1edd6...e29b7e9. Read the comment docs.

@michael-ciniawsky michael-ciniawsky changed the title add npm option feat: support custom npm clients (options.npm) Jun 20, 2017
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcxfs1991
Copy link
Contributor Author

Seems that the project is inactive. Wondering when all the pull request will be merged and the new ver will be published. We are looking forward to it.

@lcxfs1991
Copy link
Contributor Author

also add webpack 3 support in this pr.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry for the delay, I will land this as soon as possible

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "npm-install-webpack-plugin",
"version": "4.0.4",
"version": "4.0.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this, it is the maintainer/releaser responsibility to do and we have a standard process for this in place already :)

@michael-ciniawsky
Copy link
Member

@ericclemmons @insin Any objections against this change ?

@lcxfs1991
Copy link
Contributor Author

@michael-ciniawsky just revert the version number please have a look.

@michael-ciniawsky michael-ciniawsky added this to the 4.1.0 milestone Jun 30, 2017
@michael-ciniawsky michael-ciniawsky merged commit 3168f63 into webpack-contrib:master Jun 30, 2017
@michael-ciniawsky
Copy link
Member

@lcxfs1991 Thx

@michael-ciniawsky michael-ciniawsky modified the milestone: 4.1.0 Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants