-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom npm clients (options.npm
)
#113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 3 3
Lines 169 169
=======================================
Hits 154 154
Misses 15 15
Continue to review full report at Codecov.
|
options.npm
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lcxfs1991 Thx
Seems that the project is inactive. Wondering when all the pull request will be merged and the new ver will be published. We are looking forward to it. |
also add webpack 3 support in this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry for the delay, I will land this as soon as possible
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "npm-install-webpack-plugin", | |||
"version": "4.0.4", | |||
"version": "4.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this, it is the maintainer/releaser responsibility to do and we have a standard process for this in place already :)
@ericclemmons @insin Any objections against this change ? |
@michael-ciniawsky just revert the version number please have a look. |
@lcxfs1991 Thx |
some company has their own npm command with a different name ,like tnpm ,cnpm and so on.