This repository has been archived by the owner on Dec 22, 2020. It is now read-only.
fix: remove broken handling of "target": "node" #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
previously approved these changes
Mar 24, 2020
|
Yeah, a major version. Just to be on the safe side... |
this flow was never covered by any tests and got broken by mocha itself, as it's no longer bundle-compatible when targeting node. closes #89 by now throwing an error about an unsupported target. Should be noted that test files can always be bundled without mocha-loader. The resulting bundle can later be executed in node using the mocha cli.
AviVahl
force-pushed
the
remove-target-node-flow
branch
from
2addddd
to
65be42a
Compare
|
@AviVahl Do we need to implement anything else before releasing the major version? |
|
not really. go ahead. 👍 |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
This flow was never covered by any tests and got broken by mocha itself, as it's no longer bundle-compatible when targeting node.
Closes #89 by now throwing an error about an unsupported target.
Should be noted that test files can always be bundled without mocha-loader. The resulting bundle can later be executed in node using the mocha cli.
Breaking Changes
Replaced bundling errors with a proper "unsupported target" error. Not sure whether it's considered breaking to remove something that doesn't work anyway.