Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context with symbols #94

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Conversation

ricardogobbosouza
Copy link
Collaborator

Resolve #93

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #94 (e81ea59) into master (04fc3ca) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          254       253    -1     
  Branches        72        72           
=========================================
- Hits           254       253    -1     
Impacted Files Coverage Δ
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fc3ca...e81ea59. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this in copy-webpack-plugin https://github.com/webpack-contrib/copy-webpack-plugin/blob/master/src/index.js#L168, maybe we can copy/paste logic from fast-glob here

@ricardogobbosouza ricardogobbosouza merged commit 6fc6874 into master Apr 8, 2021
@ricardogobbosouza ricardogobbosouza deleted the fix-context-symbols branch April 8, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESlint output no errors or warnings when directory path includes square brackets
2 participants