fix: fails when failOnError or failOnWarning enabled

[ricardogobbosouza]

This PR contains a:

• bugfix
• new feature
• code refactor
• test update
• typo fix
• metadata update

Motivation / Use-Case

Fix when failOnError or failOnWarning is enabled and there is an error or warning from eslint locking the compilation and not displaying anything.

Resolve #51, #21, #71

Breaking Changes

Additional Info

[codecov]

Codecov Report

Merging #72 (7818502) into master (4daddf5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          245       243    -2     
  Branches        66        65    -1     
=========================================
- Hits           245       243    -2     

Impacted Files	Coverage Δ
src/ESLintError.js	100.00% <ø> (ø)
src/linter.js	100.00% <ø> (ø)
src/options.js	100.00% <ø> (ø)
src/index.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4daddf5...3ce4e43. Read the comment docs.

[alexander-akait]

Why do not set warnings and errors on empty array, when failOnError is disabled?

[ricardogobbosouza]

You're right!
Do you think failOnError should be enabled by default?

[alexander-akait]

Hard to say, don't think there is a correct answer, everyone decides how best to set up, but for me default true value is good to 0CJS, I want to fail if I have problems with linting by default

[ricardogobbosouza]

For me it makes more sense too, not to generate a breaking change

[decademoon]

It seems that failOnError and failOnWarning not only determines whether the build fails, but also whether errors/warnings will be reported. Is this intentional? I.e. if failOnError is false then lint errors are never reported.

Perhaps this code should be changed from:

eslint-webpack-plugin/src/index.js

Lines 133 to 144 in f6d26b7

	if (warnings && !options.failOnWarning) {
	// @ts-ignore
	compilation.warnings.push(warnings);
	} else if (warnings && options.failOnWarning) {
	// @ts-ignore
	compilation.errors.push(warnings);
	}
	if (errors && options.failOnError) {
	// @ts-ignore
	compilation.errors.push(errors);
	}

To

 if (warnings && !options.failOnWarning) { 
   // @ts-ignore 
   compilation.warnings.push(warnings); 
 } else if (warnings && options.failOnWarning) { 
   // @ts-ignore 
   compilation.errors.push(warnings); 
 } 
  
 if (errors && options.failOnError) { 
   // @ts-ignore 
   compilation.errors.push(errors); 
 } else if (errors && !options.failOnError) {  // <-- added
   // @ts-ignore 
   compilation.warnings.push(errors); 
 }

[ricardogobbosouza]

Its intentional #72 (review)

Please open a PR with this change if possible 😄