feat: support {String} patterns
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cletusw
commented
Oct 10, 2017
| @@ -1053,6 +1053,25 @@ describe('apply function', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('with simple string patterns', () => { | |||
| it('can move multiple files', (done) => { | |||
There was a problem hiding this comment.
Wording could be better if anyone has suggestions.
There was a problem hiding this comment.
describe('Patterns - {String}', () => {
it('Multiple Files', () => {})
})But 🐦 , all good
|
@michael-ciniawsky Please review, thanks! |
michael-ciniawsky
changed the title
{String} patterns
michael-ciniawsky
approved these changes
Oct 11, 2017
| @@ -1053,6 +1053,25 @@ describe('apply function', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('with simple string patterns', () => { | |||
| it('can move multiple files', (done) => { | |||
There was a problem hiding this comment.
describe('Patterns - {String}', () => {
it('Multiple Files', () => {})
})But 🐦 , all good
michael-ciniawsky
added
pr_action: Review
status: Approved
and removed
pr_action: Discuss
labels
|
@cletusw Please update the docs ( |
cletusw
force-pushed
the
string-patterns
branch
from
056a60b to
ccda84c
Compare
cletusw
force-pushed
the
string-patterns
branch
from
ccda84c to
f456985
Compare
|
@michael-ciniawsky Okay, I've added the changes to the README to my string-patterns branch but for some reason the PR is not updating. |
|
Never mind, it just updated. Weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150