Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Tree hierarchy in Virtualmin site dropdown #466

Closed
bilekt3 opened this issue May 24, 2016 · 13 comments
Closed

Theme: Tree hierarchy in Virtualmin site dropdown #466

bilekt3 opened this issue May 24, 2016 · 13 comments

Comments

@bilekt3
Copy link

bilekt3 commented May 24, 2016

It will be nice and helpful to see tree hierarchy in virtualmin server list dropdown. Flat hierarchy is little confusing.

@iliajie
Copy link
Collaborator

iliajie commented May 24, 2016

You mean on the navigation menu? Top right? Why select is not good?

@bilekt3
Copy link
Author

bilekt3 commented May 25, 2016

I mean this dropdown.
screen shot 2016-05-25 at 15 11 14

In old theme this dropdown respect hierarchy of servers, subserves and aliases. Now in flat structure is very confusing what belongs where. It was achieved with spaces before server name if I remember correctly.

Quick search is excellent but some sort of visualization of hierarchy might speedup my workflow. In example if I am going to find some sort of sub-server I would like to be informed about his master server somehow.

It is more clear now?

@iliajie
Copy link
Collaborator

iliajie commented May 25, 2016

A bit more, clear. Thanks. But as far as I remember, there is padding on the left for subservers already? Could you please post a screenshot of how it looks in the old theme and how you would like it to be?

@bilekt3
Copy link
Author

bilekt3 commented May 25, 2016

Yes you remember correctly. But it is weird drop down is not on my system anymore on old theme. Reason why I am interested in this is that I have 160+ domains in my virtualmin stack.

If I am thinking about improvement that indication is very tricky because filtering and spaces are not good together.

One (not only) solution might be to indicate position with spaces (icon?) and when filter is applied maintain server hierarchy i.e.: Given server list

  • - Server A
  • - - Subserver AA
  • - - Subserver AB
  • - Server B

When I start filter for example Subserver AB whole structure remains in filter:

  • - Server A
  • - - Subserver AA
  • - - Subserver AB

Any other ideas?

@iliajie
Copy link
Collaborator

iliajie commented May 25, 2016

I'll see what I can do in few hours. It might be difficult to implement.. But will see.

@bilekt3
Copy link
Author

bilekt3 commented May 25, 2016

👍 Thanks for considering this. As I said it is tricky but it might be worth it. I am surprised that nobody have similar problem.

@iliajie
Copy link
Collaborator

iliajie commented May 25, 2016

Take a look at the screenshot. It has padding for sub domains, like I mentioned.

screenshot from 2016-05-25 17-41-17

At least it's there at upcoming 18.00. Is this good enough?

@bilekt3
Copy link
Author

bilekt3 commented May 25, 2016

It is super, please note, that there is also alias (for server also sub-server). Main server view is excellent (red one).

@iliajie iliajie changed the title Tree hierarchy in virtualmin site dropdown Theme: Tree hierarchy in Virtualmin site dropdown May 26, 2016
@iliajie
Copy link
Collaborator

iliajie commented Jun 2, 2016

Ok, what exactly is missing?

@iliajie
Copy link
Collaborator

iliajie commented Jun 2, 2016

I mean there is search? What else would you want?

A
abc.com
abc1.com
abc2.com
B
bcd.com
bcd1.com
bcd2.com

This kind of stuff??

@bilekt3
Copy link
Author

bilekt3 commented Jun 5, 2016

Sorry for late response.

My note was about indentation based on real position in tree structure.

As far I know you can do following server types in Virtualmin:

  1. Server (root, in virtualmin referenced as Top server)
  2. Alias to Server (two indents for root)
  3. Sub-Server (one indent for root, in virtualmin referenced as sub-server)
  4. Alias of sub-server (one indent for sub-server, two indents for Server)
  5. Alias of sub-server with own mail (for me is same as 4)
A.com (Top server)
-- Alias AA.com (for top-server A.com)
- Sub-server AB.com
-- Alias ABB.com (for subserver AB.com)
B.com (Top server)
-- Alias BA.com (for  top-server B.com)

@iliajie
Copy link
Collaborator

iliajie commented Oct 15, 2016

It will be implemented on 18.20

@iliajie iliajie closed this as completed Oct 15, 2016
@iliajie
Copy link
Collaborator

iliajie commented Oct 29, 2016

Version 18.20 is out, please upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants