Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Split] Validate the output shape of each output #458

Closed
mingmingtasd opened this issue Aug 25, 2023 · 3 comments
Closed

[Split] Validate the output shape of each output #458

mingmingtasd opened this issue Aug 25, 2023 · 3 comments

Comments

@mingmingtasd
Copy link
Contributor

#446 (comment)

@zolkis
Copy link
Collaborator

zolkis commented Aug 25, 2023

Originally posted by @mingmingtasd in #446 (comment)

You may want to validate the output shape for the splitted output tensors.
If *splits* is an {{unsigned long}}, the [=list/size=] of the output sequence equals to *splits*. The shape of each output tensor is the same as *input* except the dimension size of *axis* equals to the quotient of dividing the dimension size of *input* along *axis* by *splits*. If *splits* is a sequence of {{unsigned long}}, the [=list/size=] of the output sequence equals to the [=list/size=] of *splits*. The shape of the i-th output tensor is the same as as *input* except along *axis* where the dimension size is *splits[i]*.

@zolkis
Copy link
Collaborator

zolkis commented Aug 25, 2023

Usually the inputs are validated in the algorithms.
Implementations may validate the results when the operation is executed, and if there are issues, signal an error.
The algorithms needs to have steps to handle errors from the platform.

@mingmingtasd
Copy link
Contributor Author

Usually the inputs are validated in the algorithms. Implementations may validate the results when the operation is executed, and if there are issues, signal an error. The algorithms needs to have steps to handle errors from the platform.

As discussed, that for split may be unnecessary, close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants