feat(composer): improvements to how dislpayName and contents are set #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phatv
reviewed
Nov 17, 2021
phatv
approved these changes
Nov 17, 2021
webex-web-client
pushed a commit
that referenced
this pull request
Nov 19, 2021
# [2.5.0](v2.4.0...v2.5.0) (2021-11-19) ### Features * **composer:** improvements to how dislpayName and contents are set ([#81](#81)) ([df3a7d0](df3a7d0))
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to make the composer behave in the same way as the thick clients in terms of setting the
displayNameandcontentfields. This also includes escaping html when markdown is disabled when there are mentions, and using only thedisplayNamewhen there aren't.I could not find the tests in this repo (if I have missed them please let me know and I will add tests to them), but I have linked my changes (after building) to the web client and, along with some additional logging on the web client side, have checked that it does behave in the same way as the mac desktop client does.