Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Chromedriver dependency #14

Closed
goosewobbler opened this issue Jan 6, 2022 · 2 comments
Closed

Review Chromedriver dependency #14

goosewobbler opened this issue Jan 6, 2022 · 2 comments
Assignees
@goosewobbler

Comments

@goosewobbler
Copy link
Member

goosewobbler commented Jan 6, 2022 •
edited
Loading

We are currently requiring chromedriver as a peerdep and initial testing suggests it is required - it seems the use of electron-chromedriver does not fulfil this.

Possible options available:

  • switch electron-chromedriver for chromedriver and change docs to reflect that chromedriver is a required peerdep
  • update wdio-chromedriver-service to make chromedriver an optional peerdep
  • something else?
@goosewobbler goosewobbler self-assigned this Jan 6, 2022
@goosewobbler
Copy link
Member Author

Needs further testing - currently moving away from the Spectron fork as testbed, in favour of https://github.com/goosewobbler/wdio-electron-service-example

@goosewobbler goosewobbler mentioned this issue Jan 6, 2022
Merged
@goosewobbler
Copy link
Member Author

Fully fixed with merge of webdriverio-community/wdio-chromedriver-service#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goosewobbler goosewobbler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goosewobbler