From 942cb416947d7c9097fc2c8126c79f5087f0587d Mon Sep 17 00:00:00 2001 From: Christian Bromann Date: Fri, 26 Apr 2024 16:35:47 -0700 Subject: [PATCH] feat: allow to set geckodriver via GECKODRIVER_PATH --- README.md | 2 +- src/index.ts | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index eddd6167..86348752 100644 --- a/README.md +++ b/README.md @@ -209,7 +209,7 @@ Type: `string` Don't download Geckodriver, instead use a custom path to it, e.g. a cached binary. Type: `string`
-Default: `process.env.GECKODRIVER_FILEPATH` +Default: `process.env.GECKODRIVER_PATH` ### `cacheDir` The path to the root of the cache directory. diff --git a/src/index.ts b/src/index.ts index e553191f..8ff20e1f 100644 --- a/src/index.ts +++ b/src/index.ts @@ -10,7 +10,12 @@ const log = logger('geckodriver') export async function start (params: GeckodriverParameters) { const { cacheDir, customGeckoDriverPath, ...startArgs } = params - let geckoDriverPath = process.env.GECKODRIVER_FILEPATH || customGeckoDriverPath + let geckoDriverPath = ( + customGeckoDriverPath || + process.env.GECKODRIVER_PATH || + // deprecated + process.env.GECKODRIVER_FILEPATH + ) if (!geckoDriverPath) { geckoDriverPath = await downloadDriver(params.geckoDriverVersion, cacheDir) }