Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.neighborhoodscout.com - Items below the map are overlapped when the viewport is set to less than 991px #77403

Closed
webcompat-bot opened this issue Jun 16, 2021 · 7 comments
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine os-mac Issues only happening on macOS. priority-normal severity-minor The site has a cosmetic issue.
Milestone

Comments

@webcompat-bot
Copy link

webcompat-bot commented Jun 16, 2021

URL: https://www.neighborhoodscout.com/ma/weston

Browser / Version: Firefox 89.0
Operating System: Mac OS X 10.15
Tested Another Browser: Yes Chrome

Problem type: Design is broken
Description: Items are overlapped
Steps to Reproduce:
At viewport widths less than or equal to 991px, the page items below the mapbox map are overlapped and misaligned on Firefox only. At the same viewport widths less than or equal to 991px on Chrome, the page items are not overlapped, and are aligned correctly.

Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added the action-needsmoderation The moderation has not yet been completed label Jun 16, 2021
@webcompat-bot webcompat-bot added this to the needstriage milestone Jun 16, 2021
@webcompat-bot webcompat-bot added the browser-fixme This requires manual assignment for the browser name label Jun 16, 2021
@webcompat-bot webcompat-bot changed the title In the moderation queue. www.neighborhoodscout.com - design is broken Jun 17, 2021
@webcompat-bot webcompat-bot added browser-firefox engine-gecko The browser uses the Gecko rendering engine and removed action-needsmoderation The moderation has not yet been completed browser-fixme This requires manual assignment for the browser name labels Jun 17, 2021
@softvision-raul-bucata softvision-raul-bucata added the os-mac Issues only happening on macOS. label Jun 18, 2021
@softvision-raul-bucata
Copy link

We appreciate your report. I was able to reproduce the issue. The items below the map are overlapped when the view port is set below 991px:

Screenshot at Jun 18 17-23-09

Tested with:

Browser / Version: Firefox Release 89.0 (64-bit)/ Firefox Nightly 91.0a1 (2021-06-17) (64-bit)/ Chrome Version Version 91.0.4472.101
Operating System: Mac OSX 10.15.6

Notes:

  1. Reproducible regardless of the status of ETP
  2. Reproducible on the latest build of Firefox Nightly
  3. Works as expected using Chrome:

Screenshot at Jun 18 17-23-56

Moving this to NeedsDiagnosis for further investigations.

@softvision-raul-bucata softvision-raul-bucata added severity-minor The site has a cosmetic issue. priority-normal labels Jun 18, 2021
@softvision-raul-bucata softvision-raul-bucata changed the title www.neighborhoodscout.com - design is broken www.neighborhoodscout.com - Items below the map are overlapped when the viewport is set to less than 991px Jun 18, 2021
@wisniewskit
Copy link
Member

Here is an interesting case of them using negative margins on flex-items to hack their layout so that it works in Chrome:

.row {
    display: flex;
    flex-wrap: wrap;
    margin-right: -15px;
    margin-left: -15px;
}

If I drop the negative margins, Chrome renders as Firefox does. It seems to be honoring the margin values, while Firefox does not. This seems to be confirmed if I add width:calc(100% - 60px) in Firefox, which fixes the layout. @dholbert, is it a known interop issue that Firefox and Chrome treat margins differently for flexboxes in this way?

@dholbert
Copy link

If I drop the negative margins, Chrome renders as Firefox does. It seems to be honoring the margin values, while Firefox does not.

Chrome is reacting to the margin values (and significantly changing its layout when they're present), and Firefox is not.

There's some floated content just before the flex container here, with class .maplite-links, and it seems to be involved -- if I remove that element, the overlapping content issue seems to go away (in Firefox as well as Chrome-with-margins-set-to-zero-to-make-it-render-like-Firefox).

I suspect this is https://bugs.chromium.org/p/chromium/issues/detail?id=1141209

@wisniewskit
Copy link
Member

Thanks. Then our way forward here will be a site patch and outreach attempt, while we wait for the Chrome bug report to be addressed.

@webcompat-bot
Copy link
Author

@dholbert
Copy link

dholbert commented May 8, 2022

I'm revisiting this after landing a fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1745310 (which would've fixed this):

I tested Nightly 2022-05-01 (before that landed fix) and can't reproduce this bug anymore, so it seems the site probably changed to work around this (or perhaps had a redesign).

@ksy36 ksy36 removed the action-needssitepatch This web bug needs a GoFaster site patch. label May 25, 2022
@softvision-raul-bucata
Copy link

The issue has been fixed and it is no longer reproducible:
Screenshot at Sep 22 12-40-56

Tested with:

Browser / Version: Firefox Nightly 107.0a1 (2022-09-21) (64-bit)
Operating System: Mac OSX 10.15.6

Closing this as FIXED

[inv_38/2022]

@softvision-raul-bucata softvision-raul-bucata added this to the fixed milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine os-mac Issues only happening on macOS. priority-normal severity-minor The site has a cosmetic issue.
Projects
None yet
Development

No branches or pull requests

5 participants