Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result of contract method .send is hard to type #6701

Closed
mpetrunic opened this issue Jan 8, 2024 · 3 comments · Fixed by #6883
Closed

Result of contract method .send is hard to type #6701

mpetrunic opened this issue Jan 8, 2024 · 3 comments · Fixed by #6883
Assignees
@avkos
Labels
4.x 4.0 related

Comments

@mpetrunic
Copy link
Contributor

If you wanna pass returned Web3PromiEvent it's hard to preserve typing. Maybe makes sense to provide some utility type for that
@mpetrunic
Copy link
Contributor Author

Also Web3PromiEvent doesn't seem to be exported

@mconnelly8 mconnelly8 added the 4.x 4.0 related label Jan 8, 2024
@avkos avkos self-assigned this Mar 8, 2024
@avkos
Copy link
Contributor

avkos commented Mar 12, 2024

@mpetrunic , Web3PromiEvent exported in web3-core package
https://github.com/web3/web3.js/blob/4.x/packages/web3-core/src/web3_promi_event.ts

@avkos avkos mentioned this issue Mar 12, 2024
Merged
17 tasks
@mpetrunic
Copy link
Contributor Author

@mpetrunic , Web3PromiEvent exported in web3-core package https://github.com/web3/web3.js/blob/4.x/packages/web3-core/src/web3_promi_event.ts

Maybe also add here: https://github.com/web3/web3.js/blob/4.x/packages/web3/src/index.ts#L336 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avkos avkos

Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Result of contract method .send is hard to type web3/web3.js
3 participants
@mpetrunic @avkos @mconnelly8