Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DeployTransactionResponse #2551

Closed
dileepfrog opened this issue Mar 21, 2019 · 2 comments
Closed

Rename DeployTransactionResponse #2551

dileepfrog opened this issue Mar 21, 2019 · 2 comments
Labels
Types Incorrect or missing types

Comments

@dileepfrog
Copy link

Description

This interface can be used to estimate gas and encode ABI data for any Ethereum tx other than a simple ETH transfer, not just contract depoys. Perhaps a better name would be TransactionData
@nivida nivida added the Types Incorrect or missing types label Mar 22, 2019
@nivida
Copy link
Contributor

nivida commented Mar 22, 2019 •
edited
Loading

I think a name like TransactionMethod would be more accurate.

Edit: Or even more specific ContractSendMethod

@dileepfrog
Copy link
Author

The contract method is actually bound to specific arguments in this object, so it's more an Invocation than just Method, of course I'm just splitting hairs now 😛

@nivida nivida mentioned this issue Mar 22, 2019
Merged
12 tasks
@nivida nivida mentioned this issue Mar 28, 2019
Merged
12 tasks
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dileepfrog @nivida